[feature/#204] [동아리 소개] API 구현 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
skytin1004
reviewed
Jan 3, 2024
.github/workflows/gradle-build.yml
Outdated
| uses: gradle/gradle-build-action@4137be6a8bf7d7133955359dbd952c0ca73b1021 | ||
| with: | ||
| arguments: build | ||
| run: ./gradlew clean build |
There was a problem hiding this comment.
uses: gradle/gradle-build-action@
대신에 run: ./gradlew clean build를 사용한 이유를 알고 싶습니다.
There was a problem hiding this comment.
환경 변수 때문인가요? 특정 버전의 gradle을 사용하기 위해서 이렇게 코드를 수정한 것인지 궁금합니다.
There was a problem hiding this comment.
application.yml에 변수 env를 넘겨줘야하는데 gradle/gradle-build-action@4137be6a8bf7d7133955359dbd952c0ca73b1021 쓰는 방식은 변수를 넘겨주는건 enterprise 버전에서만 적용된다고 그래서 저렇게 수정했어.
There was a problem hiding this comment.
gradle/gradle-build-action의 사용은 종속성 캐싱 등의 기능을 통해 빌드 시간을 단축시킬 수 있습니다. 특히, 대규모 프로젝트나 복잡한 빌드 과정이 있는 경우에 유용합니다.
직접 ./gradlew 사용은 추가 설정 없이 기본적인 Gradle 실행을 제공합니다. 간단한 프로젝트나 특별한 빌드 최적화가 필요 없는 경우에 적합할 수 있습니다.
확실히 전자의 방식이 성능면에선 우수하네
resource-server/src/test/java/com/inhabas/api/domain/board/domain/valueObject/TitleTest.java
Outdated
Show resolved
Hide resolved
resource-server/src/test/java/com/inhabas/api/domain/board/domain/valueObject/TitleTest.java
Outdated
Show resolved
Hide resolved
resource-server/src/test/java/com/inhabas/api/domain/board/domain/valueObject/TitleTest.java
Outdated
Show resolved
Hide resolved
resource-server/src/test/java/com/inhabas/api/domain/club/dto/ClubHistoryDtoTest.java
Outdated
Show resolved
Hide resolved
resource-server/src/test/java/com/inhabas/api/domain/club/dto/ClubHistoryDtoTest.java
Outdated
Show resolved
Hide resolved
...rce-server/src/test/java/com/inhabas/api/domain/club/usecase/ClubHistoryServiceImplTest.java
Outdated
Show resolved
Hide resolved
...rce-server/src/test/java/com/inhabas/api/domain/club/usecase/ClubHistoryServiceImplTest.java
Outdated
Show resolved
Hide resolved
...rce-server/src/test/java/com/inhabas/api/domain/club/usecase/ClubHistoryServiceImplTest.java
Outdated
Show resolved
Hide resolved
...rce-server/src/test/java/com/inhabas/api/domain/club/usecase/ClubHistoryServiceImplTest.java
Outdated
Show resolved
Hide resolved
whitem4rk
force-pushed
the
feature/#204
branch
from
56876ec to
b0584c7
Compare
whitem4rk
force-pushed
the
feature/#204
branch
from
d8319ed to
b0584c7
Compare
whitem4rk
force-pushed
the
feature/#204
branch
from
eebe507 to
6a07898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.